Repository navigation
Conversation
Co-authored-by: Marc Glasser <marcaaron@users.noreply.github.com>
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Documents the Describe your search natural-language filter entry point added to the Spend page by [Payment due @truph01] Add natural language filter entry point to Spend page. That PR shipped a new user-facing feature and copy with no accompanying help site coverage, so members have no documentation for it.
New article:
docs/articles/new-expensify/reports-and-expenses/Describe-Your-Search-on-the-Spend-Page.mdIt covers the single workflow of describing a search in plain English, including:
Updated articles (one cross-link each, per the cross-linking standards):
Getting-Started-with-the-Spend-Page.md— adds a pointer from the filters section and adds describe-search keywords to the front matter.Use-Search-Operators-to-Filter-and-Analyze.md— adds a pointer for members who would rather not write operator syntax.How the copy was verified: every UI label in the article was checked against the running app rather than taken from the diff — the Spend tab, the Filters button, the Describe your search entry point, the Your search input label, the description text, and the Apply button. All match the article exactly, including capitalization.
The article follows
docs/HELP_AUTHORING_GUIDELINES.md(one workflow, one#heading plus# FAQ, task-based##headings only, required front matter includinginternalScope),docs/HELPSITE_NAMING_CONVENTIONS.md(bolded UI labels in sentence case, separate web and mobile navigation), anddocs/TEMPLATE.md.Note for the reviewer: the
Fixed Issueslink is intentionally left blank — please add the correct issue link before marking this ready for review.AI Tests
npm run spell-changed— passed (3 files checked, 0 issues).docs/articles/**markdown, and the generateddocs/_data/routes.ymlis gitignored, so no routes file needs to be committed.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this is a documentation-only change with no app code.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@marcaaron, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.